Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure Appium Protocol is included when attaching to a session id #208

Merged

Conversation

allen-fang
Copy link
Contributor

There is currently a difference in drivers when a session is started through the Appium inspector and when a session is attached.

image

The commandList are different which is a result of different userPrototypes being set up in webdriver.
https://github.com/webdriverio/webdriverio/blob/e2aa001ecbf240e5240ce551acbfb19f6d004973/packages/webdriver/src/utils.ts#L182

When starting a session, webdriver will determine device type and configure the userPrototypes accordingly. However, when attaching to a session, webdriver doesn't do this which results in the difference in drivers. Since we are attaching to a session in the Appium Inspector, we can assume that the use cases are devices that are mobile so we set isMobile = true in the server options.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 16, 2021

CLA Signed

The committers are authorized under a signed CLA.

@KazuCocoa KazuCocoa changed the title Ensure Appium Protocol is included when attaching to a session id fix: Ensure Appium Protocol is included when attaching to a session id Nov 16, 2021
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KazuCocoa KazuCocoa merged commit 3ce9207 into appium:main Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants