include sauce:options by default and give job a name #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dpgraham
commented
Jan 30, 2022
dpgraham
commented
- If "sauce:options" is not set, set it so that it defaults to W3C
- Give the Appium Desktop job a name so that it's easier for Sauce Labs users to know which job came from Appium Desktop
app/renderer/actions/Session.js
Outdated
| desiredCapabilities['sauce:options'] = {}; | ||
| } | ||
| if (!desiredCapabilities['sauce:options'].name) { | ||
| const dateTime = moment().format('MMM DD -- h:mma'); |
There was a problem hiding this comment.
would it be possible to format the string according to active user datetime format settings?
There was a problem hiding this comment.
@mykola-mokhnach could you be specific, I'm not familiar with what that is.
There was a problem hiding this comment.
check Multiple Locale Support at https://momentjs.com/
app/renderer/actions/Session.js
Outdated
| @@ -250,6 +251,13 @@ export function newSession (caps, attachSessId = null) { | |||
| return; | |||
| } | |||
| https = false; | |||
| if (!desiredCapabilities['sauce:options']) { | |||
There was a problem hiding this comment.
if (!_.isPlainObject(...)) ?
app/renderer/actions/Session.js
Outdated
| if (!desiredCapabilities['sauce:options']) { | ||
| desiredCapabilities['sauce:options'] = {}; | ||
| } | ||
| if (!desiredCapabilities['sauce:options'].name) { |
There was a problem hiding this comment.
does it make sense to make 'sauce:options' to a constant?
allen-fang
pushed a commit
to projectxyzio/appium-inspector
that referenced
this pull request
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.