Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Robotic.Mobi to RobotQA #794

Merged
merged 1 commit into from
May 4, 2023

Conversation

eglitise
Copy link
Collaborator

This PR resubmits the closed PR #505, with a few changes:

  • The provider key in ServerTypes and session.server was not changed, as they were otherwise causing errors
  • Added translation key for the token label

@KazuCocoa
Copy link
Member

I don't know if this is still needed for them... Let me ping the original PR author @donmezburak

@donmezburak
Copy link
Contributor

hi @KazuCocoa . we still need this. last time, this rejected due to cache deletion however couldn't find any solution at that time. we will check this pr and problems asap.

@eglitise eglitise force-pushed the update-roboticmobi-to-robotqa branch from 985b87e to 9e9f157 Compare April 30, 2023 16:41
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good whenever the content change is approved by robot qa representative

@donmezburak
Copy link
Contributor

Hi @jlipps . it looks good for us too. Thanks.

@eglitise eglitise force-pushed the update-roboticmobi-to-robotqa branch from 9e9f157 to 80b12c3 Compare May 4, 2023 19:50
@eglitise eglitise force-pushed the update-roboticmobi-to-robotqa branch from 80b12c3 to 3c2b34d Compare May 4, 2023 19:54
@eglitise eglitise merged commit 75af1b3 into appium:main May 4, 2023
@eglitise eglitise deleted the update-roboticmobi-to-robotqa branch May 4, 2023 20:06
@eglitise
Copy link
Collaborator Author

@donmezburak FYI: these changes have been included in Inspector v2023.5.1.

shiva-guntoju pushed a commit to shiva-guntoju/appium-inspector that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants