style: enhance find element modal #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make sense to sort location strategies by performance (e.g. most performant go first)? |
|
It probably could be done, but I don't see much benefit to it. As a design, the proposed 2-row radio button style (in my opinion) doesn't really imply any sorting, unlike the current dropdown design. And different automation engines may then require different list orders, which could be annoying when working with more than one engine. |
mykola-mokhnach
approved these changes
May 25, 2023
jlipps
reviewed
May 25, 2023
shiva-guntoju
pushed a commit
to shiva-guntoju/appium-inspector
that referenced
this pull request
Feb 2, 2024
* fix: do not list unavailable locator strategies * style: increase height of selector text area * feat: add clear button to selector input field * style: replace strategy selector with segmented * fix: add missing localised string * style: render found elem count as badge * style: replace segmented with radio buttons * fix: center strategy button group for non-mobile * fix: show XCUI strategies for Mac drivers * fix: detect buttons based on automation name * style: improve design of located elem actions * style: improve locator strategy button look * style: adjust button group border/highlight * fix: replace almost duplicate translation key * style: match selected item color to source tree * fix: add missing loading state during search * style: separate tap button from send keys group * fix: clear element highlight when pressing back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides various visual improvements to the find element modal:
automationTypeHere is a demonstration of the new behavior:
refreshed-find-element-walkthrough.mp4