Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: align selected element actions design to search results #857

Merged
merged 2 commits into from
May 30, 2023
Merged

style: align selected element actions design to search results #857

merged 2 commits into from
May 30, 2023

Conversation

eglitise
Copy link
Collaborator

This PR aligns the design of selected element actions to that of the locator search results:

  • Replace send keys modal with inline input field
    • The field is flexible and will adjust to the width of the whole inspector window
  • Adjust button grouping
  • Change icon of clear button

selected-elem-actions-min-width
selected-elem-actions-max-width

@eglitise eglitise merged commit bf17128 into appium:main May 30, 2023
@eglitise eglitise deleted the match-selected-elem-actions-to-search branch May 30, 2023 12:04
jlipps
jlipps reviewed May 30, 2023
View reviewed changes
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

shiva-guntoju pushed a commit to shiva-guntoju/appium-inspector that referenced this pull request Feb 2, 2024
@eglitise @shiva-guntoju
style: align selected element actions design to search results (appiu…
03dbc39 
…m#857)

* style: match selected elem actions to search modal

* chore: remove old send keys modal code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlipps jlipps jlipps left review comments

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@KazuCocoa KazuCocoa Awaiting requested review from KazuCocoa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eglitise @jlipps @mykola-mokhnach