-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added shared credentials for Digi #772
base: main
Are you sure you want to change the base?
Conversation
One of the linters is failing because we currently don’t allow overlapping rules. I’m thinking about what to do with this. |
Want some help? |
quirks/shared-credentials.json
Outdated
{ | ||
"shared": [ | ||
"digi.ro", | ||
"digionline.ro" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the expedient thing to do here is move “digionline.ro” into the “to” of the other rule, even if it’s not 100% accurate. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, digionline.ro
is NOT obsoleted, so I'm not sure what implications does this change have.
Would
{
"from": [
"digionline.ro"
],
"to": [
"digi.ro"
]
},
{
"from": [
"digiromania.ro",
"rcs-rds.ro"
],
"to": [
"digi.ro"
],
"fromDomainsAreObsoleted": true
}
work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would <...> work?
Nope, it wouldn't work:
$ ruby .github/workflows/lint-scripts/websites-shared-credentials-duplicates.rb
The domain 'digi.ro' appears more than once!
:(
Overall Checklist
for password-rules.json
for change-password-URLs.json
https://example.com/.well-known/change-password
)for shared-credentials.json
digi.ro
digionline.ro
digiromania.ro
redirects todigi.ro
: https://digiromania.rorcs-rds.ro
redirects todigi.ro
: https://rcs-rds.roshared
, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use ashared
association fromgoogle.co.il
togoogle.com
, becausegoogle.co.il
redirects toaccounts.google.com
for sign in.)from
andto
, the new group, thefrom
domain(s) redirect to theto
domain to log in.for shared-credentials-historical.json