Add SwiftLogNoOpLogHandler.init(_: String)
#194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
`LogHandler` facotories are given a label as input and return a
`LogHandler`. Since the no-op handler doesn't care about the label
callers must provide a thunk: `{ _ in SwiftLogNoOpLogHandler() }`.
That's fine but slightly more annoying to type than it needs to be.
Modifications:
- Add `SwiftLogNoOpLogHandler.init(_: String)`
Result:
Users can create a logger with the no-op handler with:
```swift
Logger(label: "foo", factory: SwiftLogNoOpLogHandler.init)
```
instead of:
```swift
Logger(label: "foo", factory: { _ in SwiftLogNoOpLogHandler() })
```
ktoso
approved these changes
May 5, 2021
|
Do people mind doing this on in 1.4.3 or should we 1.5.0? Technically it's new API |
Let's do 1.5.0, we don't need to release 1.4.3 at all. |
|
+1 for 1.5.0, version numbers are cheap! |
|
Cool, I can cut that tomorrow morning, unless you're in a rush (feel free to do the tags and milestones dance today if in a rush) :-) |
|
No rush at all, this was just an itch I needed to scratch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
LogHandlerfacotories are given a label as input and return aLogHandler. Since the no-op handler doesn't care about the labelcallers must provide a thunk:
{ _ in SwiftLogNoOpLogHandler() }.That's fine but slightly more annoying to type than it needs to be.
Modifications:
SwiftLogNoOpLogHandler.init(_: String)Result:
Users can create a logger with the no-op handler with:
instead of: