-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics endpoint with http metrics using Prometheus client lib #1045
Add metrics endpoint with http metrics using Prometheus client lib #1045
Conversation
520889f
to
36f07e3
Compare
Hello there, |
Hi @mmianl |
Hi @randombenj |
@mmianl Yeah that's also what I would propose, thanks! |
a0d6f8e
to
4178f73
Compare
4178f73
to
3085871
Compare
Hello @randombenj, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -55,6 +55,11 @@ jobs: | |||
with: | |||
go-version: ${{ matrix.go }} | |||
|
|||
- name: golangci-lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool change, thanks!
Fixes #408
Requirements
Enable basic Prometheus compatible instrumentation capabilities
Description of the Change
Add metrics endpoint with basic http and go related metrics when running
api serve
which can be enabled or disabled by a switch in the config file (=enableMetricsEndpoint
)Checklist
AUTHORS