api: allow parameters with urlencoded names #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aptly allows create e.g. repos with a / to use those with the REST api the router needs to allow urlencoded parameters in various places to represent this. A specific example of this is the /api/repos/:name/packages path Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
sjoerdsimons
force-pushed
the
sjoerd/raw-router-paths
branch
from
32553a3
to
93f7aea
Compare
|
So this allows to have urlencoded |
Yup exactly we ended up with some repos called "badger/snake" with this change you can GET |
randombenj
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aptly allows create e.g. repos with a / to use those with the REST api
the router needs to allow urlencoded parameters in various places to
represent this. A specific example of this is the /api/repos/:name/packages path
Signed-off-by: Sjoerd Simons sjoerd@collabora.com