S3: support disabling ACL with none value
#1087
Conversation
This change lets you disable ACL when using S3 by using a configuration value of `none`. This way we maintain backward compatibility with the default setting being `private`. Fixes: aptly-dev#1067
Codecov Report
@@ Coverage Diff @@
## master #1087 +/- ##
==========================================
- Coverage 52.15% 52.13% -0.02%
==========================================
Files 73 73
Lines 11257 11259 +2
==========================================
- Hits 5871 5870 -1
- Misses 4822 4824 +2
- Partials 564 565 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@randombenj how do I get the docs updated here now that 1.5.0 has been released? Is there a docs repo to submit a PR to? |
This new configuration value was added in 1.5.0 with this PR: - aptly-dev/aptly#1087
|
@randombenj ah I found it, PR opened: |
|
This fix is not working on my side. I had to use " " instead of "none" to make it working. |
|
@AirOne70 are you sure you are running aptly version 1.5 or newer? Can you check your version? |
|
@wadey Thanks for your answer. You're right, I updated Aptly only few days before the 1.5 release. That explains it. Sorry about that! |
This change lets you disable ACL when using S3 by using a configuration
value of
none. This way we maintain backward compatibility with thedefault setting being
private.Fixes: #1067
Checklist
AUTHORS