Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the doubling of the s3 prefix #621

Closed
wants to merge 1 commit into from
Closed

Fix the doubling of the s3 prefix #621

wants to merge 1 commit into from

Conversation

MMartyn
Copy link

@MMartyn MMartyn commented Aug 16, 2017

Fixes #619

@MMartyn
Copy link
Author

MMartyn commented Aug 16, 2017

@smira I wasn't sure how to go about writing a test for this as all of the behavior is private to the method. However, I did confirm that the current tests pass.

@smira
Copy link
Contributor

smira commented Aug 16, 2017

thanks, @MMartyn! I'll take a look if we can add unit-tests for it

smira added a commit that referenced this pull request Aug 16, 2017
@smira
Fix S3 path caching double-prefix
790d858 
Original PR: #621
Fixes: #619

I've added unit-test to Martyn's PR.

Without this fix, if `prefix` is set on S3 publish endpoint,
aptly would incorrectly build path cache and re-upload every object
on publish.
@smira smira mentioned this pull request Aug 16, 2017
Merged
6 tasks
@smira
Copy link
Contributor

smira commented Aug 16, 2017

thanks, merged that change in #622

@smira smira closed this Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MMartyn @smira