Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race in API related to LoadComplete() #688

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Fix race in API related to LoadComplete() #688

merged 1 commit into from
Dec 13, 2017

Conversation

smira
Copy link
Contributor

@smira smira commented Dec 13, 2017

Fixes #686

Description of the Change

LoadComplete() modifies object, so it would cause issues if it runs
concurrently with other methods. Uprage mutex locks to write
locks when LoadComplete() is being used.

This reduces concurrency of some API calls but eliminates data races

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

LoadComplete() modifies object, so it would cause issues if it runs
concurrently with other methods. Uprage mutex locks to write
locks when LoadComplete() is being used.
@smira smira merged commit 1aa8870 into master Dec 13, 2017
@smira smira deleted the 686-race-fix branch December 13, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant