Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ugorji/go/codec to latest version #855

Merged
merged 4 commits into from
Jul 15, 2019
Merged

Conversation

smira
Copy link
Contributor

@smira smira commented Jul 12, 2019

This is re-post of PR #830 rebased to the latest master

@smira smira added the 1.5.0 label Jul 12, 2019
@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #855 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
- Coverage   64.18%   64.02%   -0.16%     
==========================================
  Files          51       51              
  Lines        6517     6533      +16     
==========================================
  Hits         4183     4183              
- Misses       1827     1843      +16     
  Partials      507      507
Impacted Files Coverage Δ
deb/local.go 84.48% <ø> (ø) ⬆️
deb/remote.go 61.65% <0%> (-1.1%) ⬇️
deb/snapshot.go 73.42% <0%> (-2.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70cd11e...82ce2f8. Read the comment docs.

@smira
Copy link
Contributor Author

smira commented Jul 12, 2019

This should fix #791, but that requires some verification

@smira
Copy link
Contributor Author

smira commented Jul 15, 2019

This seems to have backwards compatibility and also provides a way to build with latest variant of msgpack codec.

@smira smira merged commit b63c0c7 into aptly-dev:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants