Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with progress == nil causing panics #871

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

smira
Copy link
Contributor

@smira smira commented Sep 3, 2019

Part of PR #459

This prepares for more methods to be exposed via the API.

Part of PR aptly-dev#459

This prepares for more methods to be exposed via the API.
@smira smira added the 1.5.0 label Sep 3, 2019
@smira smira added this to the 1.5.0 milestone Sep 3, 2019
@smira smira requested a review from sliverc September 3, 2019 13:54
@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #871 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #871      +/-   ##
=========================================
+ Coverage    63.8%   63.8%   +<.01%     
=========================================
  Files          54      54              
  Lines        6655    6661       +6     
=========================================
+ Hits         4246    4250       +4     
- Misses       1885    1886       +1     
- Partials      524     525       +1
Impacted Files Coverage Δ
http/download.go 77.08% <40%> (-0.94%) ⬇️
deb/remote.go 61.04% <80%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e75f6...1fe531e. Read the comment docs.

@sliverc sliverc merged commit 769e984 into aptly-dev:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants