Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor update goleveldb #876

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Vendor update goleveldb #876

merged 1 commit into from
Sep 18, 2019

Conversation

smira
Copy link
Contributor

@smira smira commented Sep 17, 2019

There are number of changes which went in recently which should improve
performance: syndtr/goleveldb#226 (comment)

@smira smira added this to the 1.5.0 milestone Sep 17, 2019
There are number of changes which went in recently which should improve
performance: syndtr/goleveldb#226 (comment)
@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #876 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #876   +/-   ##
=======================================
  Coverage   63.79%   63.79%           
=======================================
  Files          54       54           
  Lines        6673     6673           
=======================================
  Hits         4257     4257           
  Misses       1890     1890           
  Partials      526      526

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c75ef85...f53a34a. Read the comment docs.

@smira smira requested a review from a team September 18, 2019 08:48
@sliverc sliverc merged commit bb66b22 into aptly-dev:master Sep 18, 2019
smira added a commit to smira/aptly-fork that referenced this pull request Sep 27, 2019
PR aptly-dev#876 actually upgraded goleveldb to 1.0.0, not to the latest master.

Recent changes to goleveldb should improve performance
syndtr/goleveldb#226 (comment)
smira added a commit that referenced this pull request Sep 27, 2019
PR #876 actually upgraded goleveldb to 1.0.0, not to the latest master.

Recent changes to goleveldb should improve performance
syndtr/goleveldb#226 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants