Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GPGFinder to work with nonstandard GPG version strings #888

Merged
merged 3 commits into from
Oct 18, 2019

Conversation

sleepdeprecation
Copy link
Contributor

Description of the Change

This changes GPGFinder to allow for nonstandard version strings.

Specifically, I have MacGPG installed instead of upstream GPG, which results in the version string reading gpg (GnuPG/MacGPG2) 2.2.17 instead of the expected gpg (GnuPG) 2.2.17

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

I'm not sure if the unchecked items are applicable. A unit test could probably be added, though I'm not entirely sure how other than possibly making a mock binary that responds to --version with the MacGPG version string and adding it to the test-bins.

Specifically, I have MacGPG installed instead of upstream GPG, which
results in the version string reading
  gpg (GnuPG/MacGPG2) 2.2.17

instead of the expected
  gpg (GnuPG) 2.2.17
@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #888 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
+ Coverage   63.77%   63.79%   +0.02%     
==========================================
  Files          54       54              
  Lines        6673     6674       +1     
==========================================
+ Hits         4256     4258       +2     
  Misses       1890     1890              
+ Partials      527      526       -1
Impacted Files Coverage Δ
pgp/gnupg_finder.go 68.65% <100%> (+0.47%) ⬆️
deb/remote.go 60.91% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da853d...3266aa3. Read the comment docs.

Copy link
Contributor

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants