-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -json output flag to list|show commands #976
Conversation
Signed-off-by: Joshua Colson <joshua.colson@gmail.com>
@lbolla Would you or someone from the team be able to provide some feedback on this draft PR? I'd like to course correct sooner rather than later if there are significant problems. Thanks. |
Signed-off-by: Joshua Colson <joshua.colson@gmail.com>
Signed-off-by: Joshua Colson <joshua.colson@gmail.com>
Signed-off-by: Joshua Colson <joshua.colson@gmail.com>
Signed-off-by: Joshua Colson <joshua.colson@gmail.com>
Signed-off-by: Joshua Colson <joshua.colson@gmail.com>
@lbolla I think this PR is ready for review. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I just added some minor comments.
Signed-off-by: Joshua Colson <joshua.colson@gmail.com>
@lbolla What is the process for aptly releases? Is there any hope for this making it into a release in the near future? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
We haven't done a release yet since when we inherited maintenance of this project. As far as I know, releases were made with Travis, which is broken (see #973). We may figure out how to release manually in the meantime. |
Signed-off-by: Joshua Colson joshua.colson@gmail.com
Fixes #
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
This PR is to add a
-json
flag to format the output oflist
andshow
commands in JSON.Note: this initial commit is a WIP with only relevant updates to the
repo
command to solicit feedback before coding formirror
,publish
, andsnapshot
.Checklist
AUTHORS