Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal for standardizing private keys #385

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Proposal for standardizing private keys #385

merged 3 commits into from
Apr 22, 2024

Conversation

gregnazario
Copy link
Contributor

@gregnazario gregnazario commented Mar 16, 2024 •
edited
Loading

This is a proposal for a standard on private keys that differentiates them from other identifiers to prevent mistakes

davidiw
davidiw approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@davidiw davidiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable, ping me when you fix it and take the next available aip number.

aips/aip-standardize-private-keys.md Outdated Show resolved Hide resolved
aips/aip-standardize-private-keys.md Outdated Show resolved Hide resolved
aips/aip-standardize-private-keys.md Outdated Show resolved Hide resolved
aips/aip-standardize-private-keys.md Outdated Show resolved Hide resolved
aips/aip-standardize-private-keys.md Outdated Show resolved Hide resolved
aips/aip-standardize-private-keys.md Outdated Show resolved Hide resolved
@gregnazario gregnazario mentioned this pull request Apr 19, 2024
Open
@thepomeranian thepomeranian merged commit ea2337c into aptos-foundation:main Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidiw davidiw davidiw approved these changes

@thepomeranian thepomeranian thepomeranian approved these changes

@movekevin movekevin Awaiting requested review from movekevin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregnazario @davidiw @thepomeranian