Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-based testing #12

Merged
merged 17 commits into from
May 10, 2022
Merged

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented May 2, 2022

Additional Changes

  • Publicize the db instance variable of the ADBDGL_Adapter for easy access
  • Solve a minor mypy issue regarding implicit reexports (issue - fix)
  • Update README
  • Bump python-arango & torch versions

Before/After results

Local testing

  • Before: ~40 seconds
  • After: ~3 seconds (not taking into account the time needed to create an ArangoDB instance with a method of choice)

Github Actions build.yml Sequence

  • Before: ~5-6 minutes
  • After: ~2 minutes

@aMahanna aMahanna self-assigned this May 2, 2022
aMahanna added a commit to arangoml/networkx-adapter that referenced this pull request May 3, 2022
Copy link

@cw00dw0rd cw00dw0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aMahanna aMahanna merged commit 0ac6af8 into master May 10, 2022
@aMahanna aMahanna deleted the feature/docker-based-arangodb-instance branch May 10, 2022 19:32
aMahanna added a commit to arangoml/networkx-adapter that referenced this pull request May 17, 2022
* Revert "Extend adapter with the functionality to export into cuGraph (#64)"

This reverts commit 808d9bf.

* mirror changes of arangoml/dgl-adapter#12

* Update setup.py

* cleanup

* fix: simplify adb_map typing

* #70: initial commit

* fix: flake8

* new: in-line coverage report

* Update abc.py

* Update release.yml

* cleanup

* fix: set default password to empty string

* set empty password

* Update adapter.py

* fix: specify requests dep
aMahanna added a commit to arangoml/networkx-adapter that referenced this pull request May 18, 2022
* Revert "Extend adapter with the functionality to export into cuGraph (#64)"

This reverts commit 808d9bf.

* mirror changes of arangoml/dgl-adapter#12

* Update setup.py

* cleanup

* fix: simplify adb_map typing

* #70: initial commit

* fix: flake8

* new: in-line coverage report

* Update abc.py

* Update release.yml

* cleanup

* fix: set default password to empty string

* set empty password

* Update adapter.py

* #72: initial commit

* Update adapter.py

* Update adapter.py

* cleanup

* cleanup release.yml

* Update setup.py

* new: import shortcut

* fix: isort

* remove: import shortcut for tests

* cleanup

* fix: switch back to manual changelog merge

* replace: set_verbose with set_logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor testing implementation as a docker-based solution
2 participants