Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build workflow #187

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Refactor build workflow #187

merged 1 commit into from
Jun 10, 2024

Conversation

webbnh
Copy link
Contributor

@webbnh webbnh commented Jun 10, 2024

Changes introduced with this PR

This PR refactors the build.yaml GitHub workflow:

  • moves the .github/scripts/gogenerate.sh to the arcaflow-reusable-workflows repo;
  • uses a reusable workflow for running go generate.

Note: this PR depends on arcalot/arcaflow-reusable-workflows#21, so the CI won't run until that PR is merged (until such time, this PR will be a draft).


By contributing to this repository, I agree to the contribution guidelines.

Copy link

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, in isolation this looks fine (and this one is draft 😆 )

@webbnh webbnh marked this pull request as ready for review June 10, 2024 21:47
- Use a reusable workflow for running `go generate`
- Move the .github/scripts/gogenerate.sh to arcaflow-reusable-workflows
@webbnh webbnh merged commit 945e114 into main Jun 10, 2024
5 checks passed
@webbnh webbnh deleted the reusable-gogenerate branch June 10, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants