Add loose_id field. #138
Merged
Add loose_id field. #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
reviewed
Aug 21, 2024
dbutenhof
approved these changes
Aug 22, 2024
dbutenhof
approved these changes
Aug 29, 2024
dbutenhof
reviewed
Aug 29, 2024
dbutenhof
approved these changes
Aug 30, 2024
|
The behavior granted by this PR is just compatibility with the field. We can change it in the future, but leaving the field out when not needed is ideal for compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
For cross-compatibility this needs to be added from the Go SDK. It is not used in the Python SDK at the moment.
I'm not sure if I handled the defaults in the best way. Let me know if you have any feedback.
By contributing to this repository, I agree to the contribution guidelines.