Convert project to use poetry and pre-commit #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portante
force-pushed
the
poetry-ize
branch
8 times, most recently
from
e7a84ab
to
0b14f68
Compare
jaredoconnell
approved these changes
Nov 23, 2022
portante
commented
Nov 24, 2022
dustinblack
requested review from
mfleader and
jdowni000
and removed request for
jdowni000
webbnh
reviewed
Nov 28, 2022
ghost
approved these changes
Nov 29, 2022
Manually applied.
Add various pre-commit checks which double-check aspects of the code.
Thanks, will do. Note that the commits are broken up so that the first 3 could be verified easier. The first 2 commits are simple automatic applications of If it would help, we could pull those out as separate PRs (all 3 in one PR, or in some combination of separate PRs). |
jaredoconnell
requested changes
Dec 6, 2022
portante
requested review from
mfleader,
webbnh and
jaredoconnell
and removed request for
webbnh
jaredoconnell
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
We add various pre-commit checks which double-check various aspects of the code.
We perform the auto-code changes from
black,isort, andflake8in separate commits to help make it easier to verify all the changes.By contributing to this repository, I agree to the contribution guidelines.