Prevent future potential UB in unix wrapper for getpwuid()
#104
Conversation
The `_passwd` variable is only used in one of the code blocks, so let's declare it in that block.
martinvonz
changed the title
martinvonz
force-pushed
the
push-lmkzyuywzywx
branch
4 times, most recently
from
bc51e20
to
34c9b06
Compare
|
The docs tests are already failing on the v1 branch |
There was a problem hiding this comment.
Thanks for opening this PR!
The cleanups make sense, although as-is I think this potentially introduces unsoundness with a potential null dereference in getpwuid_r(). I don't believe there are any existing soundness bugs with using uninitialized memory here, as the API is used with passing a pointer to uninitialized memory in the man page example (although for the related function getpwnam_r()).
I'll work on getting the doc tests passing.
While the warnings do exist, the tests are passing. The failure is due to a segmentation fault caused by your changes. |
This commit makes it so the function doesn't compile on unexpected OSs instead of returning uninitialized data.
martinvonz
force-pushed
the
push-lmkzyuywzywx
branch
from
34c9b06
to
f617aee
Compare
Heh, funny that only the doc tests broke. I've simply dropped one of the commits. |
AldaronLau
changed the title
getpwuid()
AldaronLau
changed the title
getpwuid()getpwuid()
No description provided.