Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neopool enhancements for HA #19857

Merged
merged 4 commits into from
Oct 28, 2023
Merged

Neopool enhancements for HA #19857

merged 4 commits into from
Oct 28, 2023

Conversation

curzon01
Copy link
Contributor

@curzon01 curzon01 commented Oct 28, 2023

Description:

Related issue (if applicable): add better #19811 capabilities

  • Add NeoPool hydrolysis setpoint and max in telemetry message SENSOR:
    "Hydrolysis": {
      "Data": 0,
      "Unit": "%",
      "Setpoint": 30,
      "Max": 100,
  • Add NeoPool command NPFiltrationSpeed
  • Change NeoPool sensor topic key Power to Powerunit to prevent misinterpretation as "power" by HA
  • Add SO157 for NeoPool output sensitive data (now default off = hide sensitive info)

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.14
  • I accept the CLA.

@arendst arendst merged commit b65f32c into arendst:development Oct 28, 2023
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants