Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-events): Fix events-webhook Service using non-default port #2929

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(argo-events): Fix events-webhook Service using non-default port #2929

wants to merge 1 commit into from
+3 −3

Conversation

nhavens
Copy link
Contributor

@nhavens nhavens commented Sep 19, 2024 •
edited by tico24
Loading

Resolves #2926

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@nhavens
fix(argo-events): Fix events-webhook Service using non-default port
0f60103 
Resolves argoproj#2926

Signed-off-by: Neile Havens <neilehavens@gmail.com>
@tico24
Copy link
Member

tico24 commented Sep 19, 2024

Looks good to me (other than the DCO arguing that's required)

@nhavens
Copy link
Contributor Author

nhavens commented Sep 19, 2024

Looks good to me (other than the DCO arguing that's required)

Thanks for the quick approval! I believe I've corrected the DCO issue.

@nhavens
Copy link
Contributor Author

nhavens commented Sep 19, 2024

@tico24 All checks are green now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tico24 tico24 tico24 approved these changes

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
argo-events size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modifying the default webhook port breaks the validatingwebhookconfiguration
2 participants
@nhavens @tico24