-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Upgrade go-retryablehttp to v0.7.7 #3743
base: master
Are you sure you want to change the base?
Conversation
edfaf08
to
a85feb7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3743 +/- ##
=======================================
Coverage 83.89% 83.89%
=======================================
Files 163 163
Lines 18560 18560
=======================================
Hits 15571 15571
Misses 2118 2118
Partials 871 871 ☔ View full report in Codecov by Sentry. |
Go Published Test Results2 171 tests 2 171 ✅ 2m 54s ⏱️ Results for commit a85feb7. |
E2E Tests Published Test Results 4 files 4 suites 3h 31m 8s ⏱️ For more details on these failures, see this check. Results for commit a85feb7. |
a85feb7
to
6054058
Compare
Quality Gate passedIssues Measures |
Testing Published Test Results 5 files 123 suites 3h 33m 26s ⏱️ For more details on these failures, see this check. Results for commit 6054058. |
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
6054058
to
5a34af8
Compare
Quality Gate passedIssues Measures |
Published E2E Test Results 4 files 4 suites 3h 15m 29s ⏱️ For more details on these failures, see this check. Results for commit 5a34af8. |
Published Unit Test Results2 275 tests 2 275 ✅ 2m 59s ⏱️ Results for commit 5a34af8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:
- Confirmed that all the dependency updates in
go.mod
are directly related to the upgrade ofgo-retryablehttp
to the requisite version to fix the CVE - Unit tests and E2E tests are passing, no obvious issues in 'E2E test results' logs
fixes #3700