-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expose validation webhook warnings in Argo CD UI #493
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 55.75% // Head: 55.65% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #493 +/- ##
==========================================
- Coverage 55.75% 55.65% -0.11%
==========================================
Files 41 41
Lines 4525 4537 +12
==========================================
+ Hits 2523 2525 +2
- Misses 1808 1816 +8
- Partials 194 196 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Sergey-Kizimov <sergey.kizimov@hiya.com>
Signed-off-by: Sergey-Kizimov <sergey.kizimov@hiya.com>
74781d0
to
d4fd681
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
case warning: | ||
sc.setOperationPhase(common.OperationWarning, "synced with warning") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we do the other case successful
stuff as well? i.e. delete hooks.
Any news on this one? |
@NitriKx looks like the original author is unresponsive. I think my comment still needs to be addressed. Are you up to pick this PR up and run with it? |
Sorry that I didn't answer for a long time, during my tests I found one bug, when synchronizing one object everything works correctly, but when synchronizing several objects (this should trigger several warnings), all warnings for objects are returned only for the last applied object, as I understood this is probably due to the fact that when synchronizing several objects, one session is used and several goroutines apply objects in parallel and for some reason there is no synchronization between the operation and the returned warning, I have no idea how to fix this. I need help with this |
One hack that I see here is that we can publish warning messages in the |
I haven't dived into the code, but it looks to me like there's a |
A warning handler has been added to this PR to display webhook validation warnings in the Argo CD user interface.
This PR is related to Issue posted before and PR in the ArgoCD repo.
Warnings in the ArgoCD UI will look like this: