Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure statvfs64 is declared #556

Closed
wants to merge 1 commit into from
Closed

ensure statvfs64 is declared #556

wants to merge 1 commit into from

Conversation

Im-0xea
Copy link

@Im-0xea Im-0xea commented Jun 15, 2023

I was testing btop on risc-v with musl, and I got build errors because statvfs64 is not defined, my first instinct was to just step down to statvfs(not 64) if the LFS defines are not set, #555, because of a bit of a miss understanding of mine of how they work, sorry for that >.<, anyhow this should ensure that under musl libc and glibc statvfs64 is defined.

@imwints
Copy link
Contributor

imwints commented Jun 15, 2023

This is related to #508 and will be closed in #510.

From the Musl FAQ:

-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE have nothing to do with supporting large files properly but with exposing the idiotic legacy interfaces with 64 on the end of their names (like open64, lseek64, etc.). only -D_FILE_OFFSET_BITS=64 should ever be used, anywhere, even on glibc.

@Im-0xea Im-0xea closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants