Use fmt for logging and allow to log to system daemon directly #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imwints
force-pushed
the
log
branch
4 times, most recently
from
60ad8c1
to
28fcb0b
Compare
|
Apples |
imwints
force-pushed
the
log
branch
6 times, most recently
from
756319d
to
3ca5201
Compare
|
Fixed the shell issue. You need to escape the |
aristocratos
requested changes
Sep 13, 2023
There was a problem hiding this comment.
@nobounce
Nice work!
I like the idea, but would prefer the defaults to keep the code contained (with only simple logfile logging).
But having the option to easily enable syslog or journald options would be great.
Don't forget to add documentation in the compile sections of the README.md
|
@aristocratos |
imwints
force-pushed
the
log
branch
3 times, most recently
from
bbdd822
to
d9faa05
Compare
imwints
force-pushed
the
log
branch
2 times, most recently
from
cec4904
to
cf7bee7
Compare
|
@aristocratos |
imwints
force-pushed
the
log
branch
7 times, most recently
from
e7964f8
to
59f2a05
Compare
imwints
force-pushed
the
log
branch
5 times, most recently
from
b37e6b1
to
d2f7262
Compare
|
@aristocratos |
imwints
force-pushed
the
log
branch
4 times, most recently
from
1eacc97
to
1bf7382
Compare
Avoids unnecessary recompilation
See: aristocratos#535 The logger now takes a formatting string and a number of variable arguments according to the `fmt` spec
Moving the definition of the FMT_HEADER_ONLY macro from a file to the compiler makes all code relying on this macro independent of a single file Also cleanup some unused fmt includes
If the BTOP_LOG_LEVEL is found in the environment it is parsed and overwrites the current configured log level. The --debug switch still has precedence The value of BTOP_LOG_LEVEL must match one of `Logger::log_levels` fields, being case insensitive
This commit allows for btop to log to either syslog(3) or systemd's journal
Using std::call_once instead of boolean Define some log file specific variables only if syslog or journald are not used Rename the privilege RAII wrapper and delete all operators and constructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the logger in a few ways:
fmt, See [REQUEST] Continued implementation of fmtlib #535fmt::formatfmt::printinstead ofstd::ofstreamFMT_HEADER_ONLYis now defined by Make and passed to the compiler. Other files including<fmt/*.h>are now independent of the definition inbtop_tools.hpp<syslog.h>is present, btop will log it's messages theremake ENABLE_JOURNALD=truebtop can directly log to journald. This can log interesting metadata like the source file location for each messageBTOP_LOG_LEVELenvironment variable and set the log level accordinglyOn systemd systems, with either
syslogorjournaldlogging, btops logs can be read withjournalctl -t btopIf this is not a good default, it's an easy fix to put this behind a
ENABLE_...flag!I'm curious if this is a nice feature or not. Looking forward for feedback :)