-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try get terminal size of "/dev/tty" if stdout fails #627
Conversation
d8ae898
to
c6ff5c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea!
But I think this could be reworked to be a bit more efficient.
For example if the deafult STDOUT_FILENO
fails, setting a bool that switches over to using /dev/tty
instead.
I can't quite follow what you mean by that. Currently it is checked if Where would the bool come into play? |
Syscalls cost a lot more than branching. |
fee3245
to
0293f0d
Compare
@aristocratos |
0293f0d
to
d4bf4f0
Compare
LLDB does not set the terminal sizes for stdout so try to get them for "/dev/tty". This helps to get back traces on arm64 where gdb is not supported
d4bf4f0
to
c90e3f9
Compare
LLDB does not set the terminal sizes for stdout so try to get them for "/dev/tty". This helps to get back traces on arm64 where gdb is not supported