-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Can't detect librocm 6.0.x #761
fix: Can't detect librocm 6.0.x #761
Conversation
@imwints But are you sure the minor version won't change until version 7? Wouldn't it make sense that version 7 would be 8.0.0.0 internally? |
69f0825
to
af741c8
Compare
That was irony... But I was asking why you are checking And by the current logic that would be 8.0.0.0 (or 9.0.0.0 if they are skipping one again). |
:) went over my head
I just thought if they change their scheme again and release a 7.x with the version 7.1.0.0 or similar this is save for now and would only accept the real 6.x for now. I just wanted to limit the allowed version range so this just wouldn't allow any new release. But I'm happy to remove that |
librocm reports it's version as 7.0.0.0 in the 6.0.x release series.
af741c8
to
43af034
Compare
Hm, there is also a Descriptions:
Might be an idea to test @imwints Do you have a AMD card to test with? The definition is at: https://rocm.docs.amd.com/projects/rocm_smi_lib/en/docs-6.0.0/.doxygen/docBin/html/group__VersQuer.html#ga6d4f034afcef2e50b4e8392c5dfd7a57 |
This will just give you the output of |
c.f. Upstream issue filed by @imwints. |
Huh, That makes even less sense to me... |
Will merge and create a new release later today, since I'm guessing it's unlikely anything will come from the issue in the ROCm repository in any reasonable time. |
…the function logic
librocm reports it's version as 7.0.0.0 in the 6.0.x release series.
Closes: #759