Fix spawning of Node.js binaries (.cmd files) on Windows #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunmehta
reviewed
Apr 2, 2017
| @@ -3,7 +3,16 @@ var spawn = require('child_process').spawn; | |||
| function Spawn(stream, command, args, name, output) { | |||
| var exited = false; | |||
| var ended = false; | |||
| var spawnedProcess = spawn(command, args); | |||
There was a problem hiding this comment.
Please keep spawnedProcess initialized at the top of the method here (keep undefined):
var spawnedProcess;
arjunmehta
reviewed
Apr 2, 2017
lib/Spawn.js
Outdated
| }; | ||
| } | ||
|
|
||
| var spawnedProcess = spawn(command, args, options); |
There was a problem hiding this comment.
Keeping with above comment remove var:
spawnedProcess = spawn(command, args, options);
arjunmehta
requested changes
Apr 2, 2017
arjunmehta
reviewed
Apr 2, 2017
lib/Spawn.js
Outdated
| if (process.platform === 'win32') { | ||
| options = { | ||
| // required so that .bat/.cmd files can be spawned | ||
| shell: process.env.comspec || 'cmd.exe', |
|
Made requested changes. Do you want me to rebase and squash these in a single commit? |
|
Looks good! No need to squash. I can do that over here. For now let's merge and I'll find a way of testing before publishing a new release. Thank you for your help! |
arjunmehta
approved these changes
Apr 2, 2017
|
Happy to help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes running .bat/.cmd files on Windows (and .cmd files are used to wrap Node.js binaries installed via npm and yarn) by setting
shelloptions ofchild_process.spawn()call on WIndows only.Fixes #5