Refactor all internal cmake targets to be object libraries #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
force-pushed
the
cmake_config_fix
branch
4 times, most recently
from
d1b8fdc
to
fa8a0ab
Compare
9prady9
force-pushed
the
cmake_config_fix
branch
from
fa8a0ab
to
ac12b1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change(s)
All internal cmake targets are refactored to use OBJECT library type.
Current Behavior
Prior to this change, internal sub-components are created as interface libraries which polluted the public dependency list of final static library built.
New Behavior
Static forge library interface list is clean and not confusing.
Breaking Change(s)
None to shared library users.