Skip to content

Commit

Permalink
Revert URL setter test spec deviations for now
Browse files Browse the repository at this point in the history
See web-platform-tests#2830 (comment).

This can be un-reverted when the following are fixed in the spec:

- whatwg/url#113
- whatwg/url#104
  • Loading branch information
SimonSapin authored and arronei committed Jun 14, 2016
1 parent edf7fd3 commit bd1ab1b
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions url/setters_tests.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,12 @@
}
},
{
"comment": "Spec deviation: from special scheme to not is not problematic. https://github.com/whatwg/url/issues/104",
"comment": "Can’t switch from special scheme to non-special. Note: this may change, see https://github.com/whatwg/url/issues/104",
"href": "http://example.net",
"new_value": "b",
"expected": {
"href": "b://example.net/",
"protocol": "b:"
"href": "http://example.net/",
"protocol": "http:"
}
},
{
Expand All @@ -120,12 +120,12 @@
}
},
{
"comment": "Spec deviation: from non-special scheme with a host to special is not problematic. https://github.com/whatwg/url/issues/104",
"comment": "Can’t switch from non-special scheme to special. Note: this may change, see https://github.com/whatwg/url/issues/104",
"href": "ssh://me@example.net",
"new_value": "http",
"expected": {
"href": "http://me@example.net/",
"protocol": "http:"
"href": "ssh://me@example.net/",
"protocol": "ssh:"
}
},
{
Expand Down Expand Up @@ -346,14 +346,14 @@
}
},
{
"comment": "Spec deviation: port number is removed if empty in the new value: https://github.com/whatwg/url/pull/113",
"comment": "Port number is unchanges if empty in the new value. Note: this may change, see https://github.com/whatwg/url/pull/113",
"href": "http://example.net:8080",
"new_value": "example.com:",
"expected": {
"href": "http://example.com/",
"host": "example.com",
"href": "http://example.com:8080/",
"host": "example.com:8080",
"hostname": "example.com",
"port": ""
"port": "8080"
}
},
{
Expand Down Expand Up @@ -761,14 +761,14 @@
}
},
{
"comment": "Spec deviation: port number is removed if empty in the new value. https://github.com/whatwg/url/pull/113",
"comment": "Port number is unchanged if empty in the new value. Note: this may change, see https://github.com/whatwg/url/pull/113",
"href": "http://example.net:8080",
"new_value": "",
"expected": {
"href": "http://example.net/",
"host": "example.net",
"href": "http://example.net:8080/",
"host": "example.net:8080",
"hostname": "example.net",
"port": ""
"port": "8080"
}
},
{
Expand Down

0 comments on commit bd1ab1b

Please sign in to comment.