Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing inline #144

Closed
ldcMasa opened this issue Oct 5, 2023 · 4 comments
Closed

Missing inline #144

ldcMasa opened this issue Oct 5, 2023 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ldcMasa
Copy link

ldcMasa commented Oct 5, 2023

Hello,

In file CDT_Utils.hpp, the function touchesSuperTriangle should be defined as
CDT_INLINE_IF_HEADER_ONLY
bool touchesSuperTriangle(const Triangle& t)

Otherwise, it leads to duplicate symbol errors.
@artem-ogre artem-ogre added bug Something isn't working good first issue Good for newcomers labels Oct 5, 2023
@artem-ogre
Copy link
Owner

Thanks @ldcMasa. I will fix it ASAP.

artem-ogre added a commit that referenced this issue Oct 5, 2023
@artem-ogre
#144 Add missing CDT_INLINE_IF_HEADER_ONLY
4768b22
artem-ogre added a commit that referenced this issue Oct 5, 2023
@artem-ogre
#144 Thank you, ldcMasa 🙇
4ce8bd4
@artem-ogre
Copy link
Owner

Fixed and did a new release. Thank you again.

artem-ogre added a commit that referenced this issue Oct 5, 2023
@artem-ogre
#144 Proper fix
ebbe76b
@artem-ogre
Copy link
Owner

artem-ogre commented Oct 5, 2023 •
edited
Loading

Ah, I rushed the wrong fix first. Could you please verify that the latest master fixes the problem?

@ldcMasa
Copy link
Author

ldcMasa commented Oct 5, 2023

Yes, it works fine, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ldcMasa @artem-ogre