#37 Fix bug in "is flip needed" test (isFlipNeeded) #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously flip was rejected only if both vertices of flip-candidate belong to the super-tri. The change rejects the flip if at least one vertex belongs to super-tri and original edge does not touch super-tri. If both original edge and flipped edge touch super-tri: use normal circumcircle test as a tie-breaker. Add two test files for regression testing.
artem-ogre
force-pushed
the
bugfix/37-fix-flip-needed-test
branch
from
42061fe
to
febb9a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously flip was rejected only if both vertices of flip-candidate belong to the super-tri.
The change rejects the flip if at least one vertex belongs to super-tri and original edge does not touch super-tri.
If both original edge and flipped edge touch super-tri: use normal circumcircle test as a tie-breaker.
Add two test files for regression testing.