@craigspaeth - Add prundupify to asset build #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! That's an unfortunate issue with factor-bundle, but I'm glad you discovered this plugin. Sorry for the grief! |
alloy
reviewed
May 10, 2017
| @@ -13,7 +13,7 @@ routes = | |||
|
|
|||
| ''' | |||
| /tag | |||
| ''': require('../apps/tag/client.coffee').init | |||
| ''': require('../apps/tag/client.js').default.init | |||
There was a problem hiding this comment.
Is there a need to include file extensions when using CoffeeScript? With vanilla JS there’s no need as extensions are registered with require.
There was a problem hiding this comment.
By default yes, but you can configure this in browserify with extensions.
|
Great job finding the issue, @broskoski 👨🎤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sigh, so after banging my head against this ( #1380 ) for two days, I found this issue: browserify/factor-bundle#51 . Apparently factor-bundle's de-dupe feature is incompatible with our Browserify. Someone in this thread made a browserify plugin which de-dupe's the required modules ( https://github.com/tellnes/prundupify ).
I did a cursory comparison, and it doesn't look like file sizes are much different, but you might know whether this is a bad idea or not. It does however fix the issue that I was getting with importing reaction-force client-side in production.