Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

Add a new script that generates a new sitemap based on collections in the DB #42

Merged
merged 2 commits into from
Dec 19, 2018
Merged

Conversation

yuki24
Copy link
Contributor

@yuki24 yuki24 commented Dec 17, 2018

finishes https://artsyproduct.atlassian.net/browse/GROW-1051

This is a re-write of #40 but this PR adds a script that relies on the database.

@yuki24
Copy link
Contributor Author

yuki24 commented Dec 17, 2018

I think the aws-sdk dependency is reasonable here. Also I forgot to update my own test but it should be good to go.

@yuki24
Copy link
Contributor Author

yuki24 commented Dec 17, 2018

The test seems to be failing on CI but not on my local machine... I'm out for dinner but will take a look once I get back.

@yuki24
Copy link
Contributor Author

yuki24 commented Dec 18, 2018

The build is fixed and now this is ready for review.

Copy link
Contributor

@l2succes l2succes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Yeah seems like it can't connect to the database in the tests. Let's fix that and we should be good to go

@yuki24
Copy link
Contributor Author

yuki24 commented Dec 19, 2018

The test has been fixed by 0ddb7e1 so I'll go ahead and merge this PR. Thanks!

@yuki24 yuki24 merged commit cfd59e2 into artsy:master Dec 19, 2018
@yuki24 yuki24 deleted the GROW-1051 branch December 19, 2018 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants