Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] MV3 upstream issues #128

Closed
1 of 2 tasks
asamuzaK opened this issue Dec 8, 2022 · 6 comments · Fixed by #144, #147, #148 or #149
Closed
1 of 2 tasks

[meta] MV3 upstream issues #128

asamuzaK opened this issue Dec 8, 2022 · 6 comments · Fixed by #144, #147, #148 or #149

Comments

@asamuzaK
Copy link
Owner Author

asamuzaK commented Dec 10, 2022

@asamuzaK
Copy link
Owner Author

@asamuzaK
Copy link
Owner Author

@asamuzaK
Copy link
Owner Author

asamuzaK commented Apr 5, 2023

Personal note

SVG icons are unlikely to be available:

  • It should not be considered a blocker for migrating to MV3.
  • Even if you migrate to MV3, you still need to prepare two manifest.json as before.
    action, background, icons and permissions need to be prepared for Blink.

Writing to clipboard:

  • Separate function to another file and import it.
  • Prepare replacement file for blink and include it at build time.

asamuzaK added a commit that referenced this issue Apr 5, 2023
asamuzaK added a commit that referenced this issue Apr 5, 2023
Fixes #128 for Gecko
@asamuzaK asamuzaK mentioned this issue Apr 5, 2023
asamuzaK added a commit that referenced this issue Apr 5, 2023
Fixes #128 for Gecko
@asamuzaK asamuzaK reopened this Apr 5, 2023
@asamuzaK
Copy link
Owner Author

asamuzaK commented Apr 5, 2023

Chrome cannot load SVG icons programmatically in MV3.
1353252 - manifest v3: chrome.notifications.create() doesn't support svg file for iconUrl - chromium
This would be a blocker unless remove icon support for Blink browsers.

Due to this issue, reverted MV3 migration for Gecko at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant