Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow page layout to be soft set in site config #193

Closed
mojavelinux opened this issue Dec 14, 2018 · 1 comment
Closed

Allow page layout to be soft set in site config #193

mojavelinux opened this issue Dec 14, 2018 · 1 comment
Assignees
@mojavelinux
Labels
bug v3.0.0
Milestone
v3.0.0

Comments

@mojavelinux
Copy link
Member

If the page layout is soft set in the site config (the value has a trailing @), then the page layout should not override the layout set in the front matter or AsciiDoc header.
@mojavelinux mojavelinux added this to the v2.2.0 milestone Dec 14, 2018
@mojavelinux mojavelinux self-assigned this Dec 14, 2018
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue Dec 14, 2018
@mojavelinux
resolves asciidoctor#193 allow page layout to be soft set in site config
49f040b
@mojavelinux
Copy link
Member Author

As part of this change, the default page layout should be computed in load_header and passed to the AsciiDoc processor instead of being prepended to the top of the content. This gives us more control over how the value is resolved.

mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue Dec 14, 2018
@mojavelinux
resolves asciidoctor#193 allow page layout to be soft set in site config
80d0cfd
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue Dec 16, 2018
@mojavelinux
resolves asciidoctor#193 allow page layout to be soft set in site config
f04331a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
bug v3.0.0
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@mojavelinux