Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a way to make empty front matter optional #57

Closed
mojavelinux opened this issue May 5, 2016 · 1 comment
Closed

Figure out a way to make empty front matter optional #57

mojavelinux opened this issue May 5, 2016 · 1 comment
Assignees
Milestone

Comments

@mojavelinux
Copy link
Member

Currently, it's necessary to add an empty front matter block at the top of the page, even if that block is empty (and all front matter is defined using AsciiDoc attributes). Otherwise, the AsciiDoc document is not recognized as a page. This empty front matter block makes the AsciiDoc document non-conforming by default (unless the skip-front-matter attribute is passed to the processor) and adds an extra step when migrating an AsciiDoc document to a Jekyll site.

Figure out a way, perhaps using Jekyll hooks, to make this empty front matter optional.

@mojavelinux
Copy link
Member Author

The method we need to override is Jekyll::Utils.has_yaml_header?. I think we should always return true for AsciiDoc files. We may want to put this behavior behind a switch in the configuration.

azuwis added a commit to azuwis/lede-web that referenced this issue May 24, 2016
It's necessary, jekyll-asciidoc is trying to make it optional see
asciidoctor/jekyll-asciidoc#57
@mojavelinux mojavelinux self-assigned this May 29, 2016
@mojavelinux mojavelinux added this to the v1.2.0 milestone May 29, 2016
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue May 29, 2016
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue May 29, 2016
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue May 30, 2016
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue May 30, 2016
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue May 30, 2016
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue May 30, 2016
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue May 30, 2016
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue May 30, 2016
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue May 30, 2016
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue May 30, 2016
mojavelinux added a commit to mojavelinux/jekyll-asciidoc that referenced this issue May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant