Skip to content

Commit

Permalink
Set MSRV through rust-version in Cargo.toml and validate in CI (#604
Browse files Browse the repository at this point in the history
)

[#590] introduced an unsuspecting MSRV bump.  While we're pro-ba-bly
fine having these at the benefit of better code (in this case more
appropriate `const` annotations), they should at least be clear to us
when merging through a CI failure (or up-front bump of this version in
the CI script).  At the same time setting [`rust-version` in
`Cargo.toml`] provides a more helpful "requires newer rustc" error
message (since Rust 1.56.0) instead of showing potentially tons of
irrelevant compile errors in this crate to the user.

[#590]: #590
[`rust-version` in `Cargo.toml`]: https://doc.rust-lang.org/cargo/reference/manifest.html?highlight=pack#the-rust-version-field
  • Loading branch information
MarijnS95 committed Mar 27, 2022
1 parent e537e0b commit e43e9c0
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 0 deletions.
11 changes: 11 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,17 @@ jobs:
command: check
args: --workspace --all-targets --all-features

check_msrv:
name: Check MSRV (1.59.0)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: dtolnay/rust-toolchain@1.59.0
- uses: actions-rs/cargo@v1
with:
command: check
args: --workspace --all-targets --all-features

generated:
name: Generated
runs-on: ubuntu-latest
Expand Down
1 change: 1 addition & 0 deletions ash-window/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ keywords = ["window", "ash", "graphics"]
categories = ["game-engines", "graphics"]
exclude = [".github/*"]
workspace = ".."
rust-version = "1.59.0"

[dependencies]
ash = { path = "../ash", version = "0.37", default-features = false }
Expand Down
1 change: 1 addition & 0 deletions ash/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ readme = "../README.md"
keywords = ["vulkan", "graphic"]
documentation = "https://docs.rs/ash"
edition = "2018"
rust-version = "1.59.0"

[dependencies]
libloading = { version = "0.7", optional = true }
Expand Down

0 comments on commit e43e9c0

Please sign in to comment.