Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3 missing DeviceV1_0 functions #397

Merged
merged 1 commit into from
Mar 20, 2021
Merged

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Mar 14, 2021

This adds merge_pipeline_caches, queue_bind_sparse and get_render_area_granularity to the DeviceV1_0 trait. I hope I didn't accidentally edit an autogenerated file again.

Copy link
Collaborator

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file ("safer" bindings over function-pointer calls, or at least accepting Rust types like slices instead of raw pointers) is still written by hand, all good here 👍

You could possibly improve the commit title or at least commit description to make it clear what missing functions are added. This is useful when reading the commit log (here on GH or on the commandline) without attached diff.

@Rua
Copy link
Contributor Author

Rua commented Mar 14, 2021

Done.

@MarijnS95
Copy link
Collaborator

There are generally specific length requirements (50/72) to prevent the title rolling over into the description:

image

But this is good enough, thanks!

@MaikKlein MaikKlein merged commit 81b8e3a into ash-rs:master Mar 20, 2021
@Rua Rua deleted the missing-devicev1.0 branch April 30, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants