Add VK_KHR/EXT_buffer_device_address extension #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaikKlein
approved these changes
Mar 20, 2021
MaikKlein
pushed a commit
that referenced
this pull request
May 8, 2021
…ublic (#430) * GetPhysicalDeviceProperties2: Make API functions public Fixes: 5eb39fe ("Add VK_KHR_get_physical_device_properties2 extension (#400)") * BufferDeviceAddress: Make API functions public Fixes: 98d66c6 ("Add VK_KHR/EXT_buffer_device_address extension (#405)") * GetMemoryRequirements2: Make API functions public Fixes: d8d7423 ("Add VK_KHR_get_memory_requirements2 extension (#401)") * Maintenance1/Maintenance3: Make API functions public Fixes: a0a1f5d ("Add VK_KHR_maintenance extensions (#406)") * Globally remove all `allow(dead_code)` exceptions This is hiding the fact that some extension functions are inadvertently not public and hence unusable by crate users, nor does it enforce clean coding practices. In addition remove `ash/src/allocator.rs` which does not appear to be used (anymore?) and isn't in a working state anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension comes in both a KHR and an EXT version, so I included them both for completeness.