generator: pSampleMask setter should write NULL if slice is empty #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per [1] no explicit length field is available for `pSampleMask`, this is based on `ceil(rasterizationSamples/32)` instead. It is valid to not set an array for `pSampleMask` (under normal circumestances this is signaled by setting the length to zero, and the array pointer is ignored) but this has to happen by setting the pointer to `NULL`. [1]: #256
MarijnS95
force-pushed
the
psamplemask-null
branch
from
dfd86e9
to
c7921ed
Compare
Ralith
approved these changes
May 11, 2021
MaikKlein
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256
As per #256 no explicit length field is available for
pSampleMask, this is based onceil(rasterizationSamples/32)instead. It is valid to not set an array forpSampleMask(under normal circumestances this is signaled by setting the length to zero, and the array pointer is ignored) but this has to happen by setting the pointer toNULL.EDIT: And so Erupt followed suit 😬 https://gitlab.com/Friz64/erupt/-/commit/5a0574a0f0c29330f15803dc0475c06bd88438c7 👀