Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generator: Small code cleanups #439

Merged
merged 3 commits into from
May 18, 2021
Merged

generator: Small code cleanups #439

merged 3 commits into from
May 18, 2021

Commits on May 17, 2021

  1. generator: Simplify contains+insert pairs to just insert() 

    Insert returns true when the value was inserted, false when it was
already present in the set.
    @MarijnS95
    MarijnS95 committed May 17, 2021
    Configuration menu
    Copy the full SHA
    2fb307b View commit details
    Browse the repository at this point in the history

  2. generator: Strictify "Vk"/"vk" prefix stripping with strip_prefix+unwrap 

    This way we are sure only the expected prefix ("Vk" or "vk") is
stripped, anything else panics the generator.
    @MarijnS95
    MarijnS95 committed May 17, 2021
    Configuration menu
    Copy the full SHA
    ee9ad52 View commit details
    Browse the repository at this point in the history

  3. generator: format_ident can format strings directly

    @MarijnS95
    MarijnS95 committed May 17, 2021
    Configuration menu
    Copy the full SHA
    b4b8746 View commit details
    Browse the repository at this point in the history