Remove experimental AMD extensions. #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me, these look pretty niche and they cost maintenance effort. |
MarijnS95
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
I can definitely sympathize with that. This extension has been a "pain" at times to update due to having code that mimicks what is autogenerated.
If anyone wants this extension back there should be some effort to write out the types and commands in "vk.xml format" and make that mergeable in the generator.
The extensions haven't being promoted to actual extensions within a long time frame and don't provide any value in its current state.
msiglreith
force-pushed
the
remove-ext-exp
branch
from
d0b9d33
to
497d253
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extensions haven't being promoted to actual extensions within a long time frame and don't provide any value in its current state. I added them some long time ago but not using them anymore since I switched my IHV. As I guess noone else has use for them I would propose to just drop them.