Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions/khr: Add VK_KHR_device_group #631

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Conversation

MarijnS95
Copy link
Collaborator

@MarijnS95 MarijnS95 commented Jun 4, 2022

Depends on #629, #630.

@MarijnS95 MarijnS95 mentioned this pull request Jun 4, 2022
ash/src/extensions/khr/device_group_creation.rs Outdated Show resolved Hide resolved
ash/src/extensions/khr/device_group.rs Show resolved Hide resolved
@Ralith
Copy link
Collaborator

Ralith commented Jun 4, 2022

Depends on #631

This is #631, though.

@MarijnS95
Copy link
Collaborator Author

Depends on #631

This is #631, though.

Good catch, must have been #630.

@MarijnS95 MarijnS95 force-pushed the khr-device-group branch 2 times, most recently from f1efdf6 to 6ebdf3d Compare June 5, 2022 10:42
@MarijnS95 MarijnS95 requested a review from Ralith June 5, 2022 19:09
local_device_index: u32,
remote_device_index: u32,
) -> vk::PeerMemoryFeatureFlags {
let mut peer_memory_features = mem::zeroed();
Copy link
Contributor

@i509VCB i509VCB Jun 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would MaybeUninit make more sense here and in the other uses to initialize flags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants