extensions/khr/ray_tracing_pipeline: Set length of capture-replay shader handle buffer after filling #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
approved these changes
Sep 21, 2022
MarijnS95
changed the title
MarijnS95
changed the title
MarijnS95
pushed a commit
that referenced
this pull request
Sep 22, 2022
…der handle buffer after filling (#658)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the capacity is allocated but the length of the vector is not set, the vec returned from
get_ray_tracing_capture_replay_shader_group_handleswill always appear to be empty. I checked for other mistakes of this nature and did not locate any.