Replace const fn name() with associated NAME constants
#715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
fn-name-to-assoc-const
branch
from
50f8309
to
3a63054
Compare
MarijnS95
force-pushed
the
fn-name-to-assoc-const
branch
4 times, most recently
from
5102303
to
e288193
Compare
Ralith
approved these changes
Mar 9, 2023
|
e288193 (this PR): $ hyperfine -p 'cargo clean -p ash' 'cargo b -p ash'
Benchmark 1: cargo b -p ash
Time (mean ± σ): 6.105 s ± 0.057 s [User: 6.905 s, System: 0.529 s]
Range (min … max): 6.046 s … 6.228 s 10 runs$ hyperfine -p 'cargo clean -p ash' 'cargo b -p ash'
Benchmark 1: cargo b -p ash
Time (mean ± σ): 6.126 s ± 0.107 s [User: 6.916 s, System: 0.517 s]
Range (min … max): 5.994 s … 6.373 s 10 runsThat's identical. |
`CStr::from_bytes_with_nul_unchecked` is `const`-stable since Rust 1.59 which is already required for `ash` so it is high time to finally turn these inlined `name()` functions into associated constants (which is a breaking change in itself that cannot be backported).
MarijnS95
force-pushed
the
fn-name-to-assoc-const
branch
from
e288193
to
a895673
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #716
CStr::from_bytes_with_nul_uncheckedisconst-stable since Rust 1.59 which is already required forashso it is high time to finally turn these inlinedname()functions into associated constants (which is a breaking change in itself that cannot be backported).